Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Firefox for Android: Controls are now in a menu, providing a less int… - #6617

Merged
cooperq merged 1 commit into
EFForg:masterfrom
Hainish:android-subtle-ui
Aug 30, 2016
Merged

cooperq merged 1 commit into
EFForg:masterfrom
Hainish:android-subtle-ui

Conversation

@Hainish

@Hainish Hainish commented Aug 27, 2016

Copy link
Copy Markdown
Member

…rusive UI (fixes #6036)

Comment thread utils/android-push.sh
adb push "../$XPI_NAME" /sdcard/"$XPI_NAME"
adb shell am start -a android.intent.action.VIEW \
-c android.intent.category.DEFAULT \
-d file:///mnt/sdcard/"$XPI_NAME" \

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want Firefox to open a new tab to the folder rather than directly to the apk file.

This is because Firefox no longer prompts to install addons from direct links, it only does so if you manually click on the link to the APK from the directory listing

@Hainish

Hainish commented Aug 27, 2016

Copy link
Copy Markdown
Member Author

This is ready for review @cooperq @jsha

@Hainish

Hainish commented Aug 29, 2016

Copy link
Copy Markdown
Member Author

hold off on merge for now, need to make a few changes

@Hainish
Hainish force-pushed the android-subtle-ui branch from c63b292 to 78a5bfa Compare August 30, 2016 00:58
@Hainish
Hainish force-pushed the android-subtle-ui branch from 78a5bfa to e93fad6 Compare August 30, 2016 01:00
@Hainish

Hainish commented Aug 30, 2016

Copy link
Copy Markdown
Member Author

This is ready to check & merge @cooperq

@cooperq

cooperq commented Aug 30, 2016

Copy link
Copy Markdown
Contributor

lgtm

@cooperq
cooperq merged commit cd77aaa into EFForg:master Aug 30, 2016
@Hainish
Hainish deleted the android-subtle-ui branch February 23, 2018 01:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move HTTPS Everywhere icon to submenu on Firefox Android

2 participants